Check entity urls properly [#1017444]

In D7, due to alter hooks, the following code can be considered naiive, and needs a refactor:

/**
 * Implements hook_menu_link_insert().
 */
function menu_node_menu_link_insert($link) {
  if ($link['router_path'] != 'node/%' || !isset($link['mlid'])) {
    return;
  }
  $nid = str_replace('node/', '', $link['link_path']);
  if ($node = node_load($nid)) {
    menu_node_record_save($node, $link);
  }
}

This is because modules may alter the canonical router_path of entities.

We may also need to refactor the update hook to ensure that the router_path is still viable on update.

Comments

Comment #1

joglin commented 28 March 2012 at 21:25

Menu module has the same bug.

/**
 * Implements hook_node_delete().
 */
function menu_node_delete($node) {
  // Delete all menu module links that point to this node.
  $result = db_query("SELECT mlid FROM {menu_links} WHERE link_path = :path AND module = 'menu'", array(':path' => 'node/' . $node->nid), array('fetch' => PDO::FETCH_ASSOC));
  foreach ($result as $m) {
    menu_link_delete($m['mlid']);
  }
}