I added a plugin to support the module: Group content menu

CommentFileSizeAuthor
#5 3202617-group-content-menu-for-v2.patch9.14 KBjaroslav červený
0001-group-content-menu-plugin.patch1.87 KBjaroslav červený

Comments

Jaroslav Červený created an issue. See original summary.

jaroslav červený’s picture

jaroslav červený commented
Status: Patch (to be ported) » Needs review
jaroslav červený’s picture

jaroslav červený commented
Title: Support for Group contnet menu » Support for Group content menu
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Hey @Jaroslav Červený, thanks for the patch.

It looks good to me, but it would be awesome if you could write test for this patch.
Probably we need to place this test inside MODULE_ROOT/tests/modules a new module that has dependency on Group module.
See this `core/modules/aggregator/tests/modules/aggregator_test_views/aggregator_test_views.info.yml`
and `\Drupal\Tests\menu_multilingual\Functional\MenuMultilingualMenuBlockTest::setUp`

jaroslav červený’s picture

jaroslav červený commented
StatusFileSize
new 3202617-group-content-menu-for-v2.patch9.14 KB

My previous `group_content_menu` patch stopped working after the update because 2.x no longer uses the old block
class override approach. What fixed it for us was:
- adding `menu_multilingual_block_view_group_content_menu_alter()`
- extending `Helpers::isMenuBlock()` to recognize `group_content_menu` via `getBaseId()`

With that change, the multilingual block settings appear for `group_content_menu` blocks again and untranslated items
are filtered correctly. I also added a functional regression test for this behavior.

jaroslav červený’s picture

jaroslav červený commented
Version: 8.x-1.x-dev » 2.0.0
jaroslav červený’s picture

jaroslav červený commented
Status: Needs work » Needs review