Closed (fixed)
Project:
Menu Block Split
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
29 Mar 2008 at 00:36 UTC
Updated:
21 Feb 2009 at 16:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
robertgarrigos commentedI'll work on this.
Comment #2
swentel commentedHi, I have a first attempt to port this module to D6.
It's a patch against 5.x-2.0-beta1, but
It works fine here, but I'm not sure if it's the right way since the menu system was completely overhauled. The patch completely overhauled the module codewise too because of this. I do hope it's a good starting point though.
Comment #3
swentel commentedComment #4
MatthijsG commented* subscribing
Comment #5
thomas23@drupal.org commentedsubscribing...
Comment #6
thomas23@drupal.org commentedOn my site it doesn't work at all. First when enabling the module I got this warning
I changed menu_hook to this:
Now I get no warning and also the permissions flag all right. But still no set-up options (haven't used this module before) and /admin/settings/mbs has access denied.
Would appreciate people with more insides to look at this.
Cheers.
Comment #7
thomas23@drupal.org commentedComment #8
thomas23@drupal.org commentedComment #9
B00N commentedHi,
i made a new version for version 6.x, based on the 5.x-2.0-beta1 version. It works fine for me, maybe someone need it.
Greets Franzer
Comment #10
robertgarrigos commentedThanks Franzer. I reviewed your code and made some minors changes to:
1.- Not trigger any error when php is set to show all errors and notices
2.- To be able to use the navigation menu (system module) as well as any user created menu (menu module). It wasn't working with the navigation menu.
3.- There is a few lines in one function which are not being used, so I commented them as they were triggering a php notice error
I upload a patch to apply on the previous uploaded file. Would you review this patch, please, so I could create a new beta release for this version 6 if this is OK?
Thanks again.
Comment #11
swentel commentedDownloaded the beta and did the patch in #10.
Works fine here. marking as rtbc
Comment #12
B00N commentedHi,
i also reviewed the code and tested the module. It works. Please create a new beta release.
I think about a other modification: A flag in the settings, where the user can decide whether the level 0 marked active when sub-items are selected.
Franzer
Comment #13
thomas23@drupal.org commentedFranZer, a very nice and usefull idea. I'd like to see this option and would test it.
Cheers.
Comment #14
B00N commentedso, here's the promised patch and also a new *.pot and a german language file.
Comment #15
robertgarrigos commentedThanks you for your work. There is a new 6.x-1.2 release. I forgot to include the pot file into the release, so it is only in the dev tarball. It'll be included in a next release.
Comment #16
robertgarrigos commented