I know lots of D6 sites that would benefit from this.

CommentFileSizeAuthor
#4 memcache_status-n2106489-4.patch4.22 KBdamienmckenna
#3 memcache_status-n2106489-3.patch4.29 KBdamienmckenna
#1 memcache_status-n2106489-1.patch4.33 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new memcache_status-n2106489-1.patch4.33 KB

This is a port of the current -dev and includes #2106491: Make Libraries API dependency optional.

iameap’s picture

iameap commented
Status: Needs review » Needs work

Awesome. Thanks for putting in the effort, @DamienMcKenna!

+++ b/memcache_status.module
@@ -1,35 +1,28 @@
 function memcache_status_menu() {
-  $items['admin/reports/status/memcache'] = array(
-    'title' => 'Memcache',
+  $items['admin/reports/memcache'] = array(
+    'title' => 'Memcache status',

Any reason for the path change? My intention was for the convention to match the existing PHP/APC/SQL status pages (if the modules are installed, in the latter two cases).

Also note my comments in #2106491: Make Libraries API dependency optional.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new memcache_status-n2106489-3.patch4.29 KB

I moved the status page back to where it was originally.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new memcache_status-n2106489-4.patch4.22 KB

Changed the title back to just "Memcache".

iameap’s picture

iameap commented

Looks good to me. Thanks, Damien! Committed 42f5ab5.

I'm going to open up a dev release of the 6.x-1.x branch; once that's processed, if you could download from there, test, and report back that it works, I'll mark this as closed and tag/release a 6.x-1.0. In particular, focus on the admin/reports/status page and ensure the hook_requirements implementation works as expected.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I tested out the -dev version, it works fine.

iameap’s picture

iameap commented
Status: Needs review » Fixed

Thanks, Damien! 6.x-1.0 (and 7.x-1.2) released!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.