First off, thank you for your work on this. I've been trying to build a materializecss base theme for a while not and then realized you've started this. Hopefully I can help push this along.

I've started from scratch with a fresh install of D8 running on Docker4Drupal. So far everything seems to be working well. I followed the instruction on installing.

When I ran gulp I noticed none of my css files were generated. I took a look inside my gulpfile.js file and noticed that the STARTERKIT placeholder wasn't changed with the other files during the Drush run.

CommentFileSizeAuthor
#5 gulpfile-update-drush-subtheme-2864010-5.patch656 bytesdenes.szabo
#3 gulpfile-update-drush-subtheme-2864010-3.patch803 bytesgrshane
themes_and_gulpfile_js_and_web_—_docker-compose_◂_docker-compose_exec_--user_82_php_sh_—_103×35.png181.68 KBjlockhart

Comments

jlockhart created an issue. See original summary.

denes.szabo’s picture

denes.szabo commented
Assigned: Unassigned » denes.szabo

Seems, this issue does not depends on Docker install.
I am investigating it and fix it soon.

Thank you for your report!

grshane’s picture

grshane commented
Status: Active » Needs review
StatusFileSize
new gulpfile-update-drush-subtheme-2864010-3.patch803 bytes

I was able to add gulpfile.js to the files that were being searched to change "STARTERKIT" in the file.

I'd like to help more with the project as well.

denes.szabo’s picture

denes.szabo commented

@grshane: thx, but it was assigned to me = I am working on it.

denes.szabo’s picture

denes.szabo commented
StatusFileSize
new gulpfile-update-drush-subtheme-2864010-5.patch656 bytes

We have a list of files which need to handle (replace strings, actually) by the Drush command. I added the gulpfile.js there - just removed the comment.

  • Denes.Szabo committed de81edb on 8.x-1.x 
    Issue #2864010 by Denes.Szabo, grshane, jlockhart: Gulpfile.js not...
jlockhart’s picture

jlockhart
Primary language English
Location PNW Washington
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

denes.szabo’s picture

denes.szabo commented
Status: Reviewed & tested by the community » Fixed

Thanks!

denes.szabo’s picture

denes.szabo commented
Status: Fixed » Closed (fixed)