Generated with the help of an LLM.

Problem/Motivation

The reviews of #3631545: Turn Mapillary organizations into groups with members, roles and content left smaller findings that were deferred. Most are internal, but some change what users see.

Steps to reproduce

  1. As a non-member, open a public organization: 403.
  2. Add an image to an organization by hand: its sequence, detections and map features are not added.
  3. As the organization's Importer, import that image again: refused.
  4. Open a listing with ?organization=abc: every row is listed.

Proposed resolution

  • Public organizations are visible to non-members; members-only ones stay closed.
  • Content added by hand brings its sequence, detections and map features, and can be imported again.
  • The organization filter becomes a select list of the organizations the viewer may see.
  • Remove the unused group permission add mapillary content.
  • Smaller fixes in access caching, queries, imports, the update from 1.0.0-alpha6 and notice texts; more tests; less repeated code; two deprecations reported by the next major phpstan job.

Remaining tasks

  • Merge request.
  • Review.

User interface changes

  • Public organization pages open for non-members.
  • The organization filter is a select list.
  • "Member since" is shown on memberships.

API changes

  • The group permission add mapillary content is removed.

Data model changes

  • Post updates revoke the removed permission, replace the filter in existing views and add the "Member since" display component.

Issue fork mapillary-3633409

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

orkutmuratyilmaz created an issue. See original summary.

orkutmuratyilmaz opened merge request !19

  • orkutmuratyilmaz committed cd1ea82d on 1.0.x 
    test: #3633409: Cover a membership in a group of another type in the API...

  • orkutmuratyilmaz committed 08ea3e3c on 1.0.x 
    test: #3633409: Check the old field configuration only when the fixture...

  • orkutmuratyilmaz committed a6877f88 on 1.0.x 
    test: #3633409: Replace the two calls the next major phpstan job reports...

  • orkutmuratyilmaz committed 1ada2366 on 1.0.x 
    fix: #3633409: Say so when the membership form cannot save a Mapillary...

  • orkutmuratyilmaz committed 77e8dd67 on 1.0.x 
    fix: #3633409: Name the organization of the old membership in the notice...

  • orkutmuratyilmaz committed f9d42106 on 1.0.x 
    docs: #3633409: Document that only the default display of a listing gets...

  • orkutmuratyilmaz committed 85235a2c on 1.0.x 
    docs: #3633409: Describe the organization filter as a select list in the...

  • orkutmuratyilmaz committed 9bd84399 on 1.0.x 
    fix: #3633409: Revoke the permissions of an uninstalled submodule from...

  • orkutmuratyilmaz committed 648f791d on 1.0.x 
    fix: #3633409: Answer 404 for the mismatched content page until Group is...

  • orkutmuratyilmaz committed 9c99ece2 on 1.0.x 
    fix: #3633409: Carry the content language settings of the old bundle to...

  • orkutmuratyilmaz committed c9507175 on 1.0.x 
    fix: #3633409: Copy the display components of every shared mode and the...

  • orkutmuratyilmaz committed d56b5015 on 1.0.x 
    fix: #3633409: Save the Mapillary organization ID of a refreshed image...

  • orkutmuratyilmaz committed bc560fd2 on 1.0.x 
    fix: #3633409: Delete the new sequence of a refused import only when no...

  • orkutmuratyilmaz committed 65196d3c on 1.0.x 
    fix: #3633409: Keep the map feature option of the detection import form...

  • orkutmuratyilmaz committed 11ec9624 on 1.0.x 
    fix: #3633409: Memoize the organizations an importer may import for and...

  • orkutmuratyilmaz committed 586688fd on 1.0.x 
    fix: #3633409: Relate the content of an image added to an organization...

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.