Closed (fixed)
Project:
MakeUp
Version:
7.x-1.0-beta2
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
24 Jan 2014 at 09:02 UTC
Updated:
27 Jan 2014 at 00:41 UTC
Jump to comment: Most recent
Just came over from Imagefield CSS. Both great projects!
Getting error:
Notice: Undefined variable: inline_css in makeupimg_css_generator() (line 178 of /var/www/companyofanimals/sites/all/modules/makeup/modules/media/makeupimg/makeupimg.module).
On node page when trying to use this.
I have replicated this issue with clean install of Drupal with/ without breakpoints with all versions of MakeUp.
There is also no field formatting options in the image formatter when I select CSS Decleration.
This is unexpected as Imagefield CSS had loads (breakpoints, css selector fields etc).
Is there anything I could be missing?
Thanks,
James
Comments
Comment #1
JamesMugford commentedComment #2
JamesMugford commentedComment #3
JamesMugford commentedComment #4
sashainparisHi James,
I will have a look at it by the end of the day (Paris, France).
Alexandre
Comment #5
sashainparisUntil then, could you provide me your settings please?
Thanks!
Alexandre
Comment #6
JamesMugford commentedHi Alexandre,
Great, here it is:
Sorry for large post.
Just let me know if you meant a settings file other than settings.php
Best,
James
Comment #7
sashainparis:-)
I was just talking about your Formatter settings for your MakeUP Image field.
Comment #8
JamesMugford commentedThat's my problem, the formatter settings form does not appear when I enable the CSS Decleration formatter.
I still get the forms for other field formatters (Image, Rendered File, Download Link, Image Delta etc)
So in other words, when I try to enable CSS Decleration in Display Settings, no cog icon appears to the right of the corresponding image row, where as other formatting settings does get this settings cog button.
I can provide any other logs if this is helpful?
Comment #9
sashainparisOK, here is the point.
I wanted to make my files shorter and easier to maintain... so I moved 2 hooks (formatter form and formatter summary) to a makeupimg.formatter_settings.inc - that is always loaded by the info file.
Obviously, Drupal 7 is not happy with that (but will probably in D8 with autoload, etc.).
So: I'll change this before the end of the WE è maybe today.
In the meanwhile, you have to:
- move all code from makeupimg.formatter_settings.inc to the makeupimg.module file
- and flush cache.
If you delete this now empty file, you will have to delete the include line in the info file too.
It should be OK: please give feedback.
I will close this issue when it's commited.
Some other changes are expected to be commited for MakeUp Title ans MakeUp Line: So it will make a Beta3 by the end of the WE.
Alexandre
Comment #10
sashainparisComment #11
JamesMugford commentedSounds good.
Just tried that, but no dice :/
here is the file:
http://pastebin.com/DrK5hGmg
This is based off of Beta 3.
I also commented out the files in the .info file.
I am sure your superior coding skills will have a better chance.
Comment #12
sashainparisFixed as Beta3.
Comment #13
JamesMugford commentedGreat stuff, works a treat.