Problem

On some CE-Views pages the recent update to 1.4 resulted in this error:
TypeError: Drupal\lupus_decoupled_views\Plugin\views\display\CustomElementsPage::buildCustomElement(): Argument #3 ($rows) must be of type array, null given, called in /app/web/modules/contrib/lupus_decoupled/modules/lupus_decoupled_views/src/Plugin/views/display/CustomElementsPage.php on line 91 in Drupal\lupus_decoupled_views\Plugin\views\display\CustomElementsPage->buildCustomElement() (Zeile 78 in /app/web/modules/contrib/lupus_decoupled/modules/lupus_decoupled_views/src/Plugin/views/display/CustomElementsViewsDisplayTrait.php).

Proposed resolution

Issue fork lupus_decoupled-3562150

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented

This seems to happen when pages are empty, but probably would also happen when they are mis-configured with a wrong style. we need to improve the code to be more defensive here.

fago opened merge request !139

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

  • fago committed a5d6dc15 on 1.x 
    fix: #3562150 Fatal error on empty custom-elements Views pages

By: fago
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

the fix works + comes with test coverage. Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.