language_sections with ls_titles empties out node body on display

"Finally, the whole ls_titles_process() code attempts to give the impression that it stores all kinds of title data in $saved ..."

Excuse me? My code doesn't attempt to give impressions. Admittedly, it may not actually work as intended, but it certainly doesn't pretend to be anything other than what it was designed for.

Perhaps you could offer a working patch to fix the behaviour you are complaining about?

FYI, the use of a static array is because the $op == 'process' code will get called twice when LS_Titles is in use. *If* there is a bug here it is in LS_Extras and not in Language Sections, so I'm closing this. Please re-post in the LS_Extras issue queue, thank you.

I apologise, I probably jumped at you - I had just arrived home after more than four hours driving!

Thanks for the patch. However, now reading your comments and looking again I think I see what the underlying problem is - it's a version mismatch between Language Sections and LS Extras - if you look at language_sections-6.x-2.x-dev.tar.gz you will see (line 38 onwards) ...

function language_sections_filter($op, $delta = 0, $format = -1, $text = '', $cache_id = FALSE) {

      ...

      // Extract title if present.
      if (function_exists('ls_titles_process')) {
        $out = ls_titles_process('set', $out, $format, $cache_id);
      }

... i.e. it has the ·$cache_id parameter in there - the released versions should be compatible (unless I made a mistake). So, please try the current (non-dev) releases of both modules, and if that doesn't work then the dev releases should work together.

Additional info:

I agree that the flow of the code is difficult to follow, and that's due to the way that it has to work - to keep titles processing in a separate module and keep the Language Sections input filter as simple as possible for people who do not want the titles functionality (the majority.) This in turn relates to the history of the module - the titles functionality was added in response to demand from a few users.

So, under normal circumstances (called directly from check_markup), if a title: line is included in the text, it must be removed from the text - that is why we have:

$out = ls_titles_process('set', $out);

... which will (should!) simply return $out after removing the title: line, if present.

I notice I already had the following on the LS Extras project page under the heading Development version

The current dev version includes a new module LS Search which addresses #361069: Only default language is indexed for search and needs the current dev release of Language Sections in order to work.

So hopefully its a case of RTFM :) but, if you can confirm that the released versions doe not work together, please let me know.

Thanks for the info. Ok, investigated more and confirmed it's a bug in 1.8, details below.

As an aside, from a design perspective, the whole LS Titles concept is arguably a bit of a hack! I don't really like it, but added it in response to feedback from a few members of the community. I am focussed on *not* breaking Language Sections in order to support LS Titles - Language Sections has many users and LS Titles has very few. For the same reason, I think this issue belongs here and not in the Language Sections queue - Language Sections works fine for people who are not using LS Titles (and that's 95% of them.)

The ls_titles_process function is not meant to be a generic API, it's only intended for use internally by LS modules. Clearly it was intended to produce valid results when optional parameters are omitted -- they are optional to allow it to work with either the dev release or current release of Language Sections (but there is a bug...)

In LS Extras 1.7 we had:

function ls_titles_process($op = 'set', $text = FALSE, $format = FALSE) {
 ...

i.e the $id parameter was added in 1.8 - that release was primarily to provide better Views support (added ls_node_title() function). That version also tried to provide some performance enhancements, which introduced the $id parameter. That change was supposed to be backward compatible with the existing Language Sections release (2.5), hence $id needed to be an optional parameter. Yes, looking now at the code, it doesn't work properly, and I probably made the mistake of testing with the dev version of Language Sections installed rather than the 2.5 release. So, unintentionally, LS Extras 1.8 is not compatible with Language Sections 2.5 because it fails to calculate the $id value if not passed by the caller. The bug was introduced in LS Extras 1.8. The two possible solutions are (1) Fix LS Extras or (2) Upgrade Language Sections. So for the short term, let's fix LS Extras rather than make an unnecessary new release of Language Sections which would only be relevant to a handful of users.

Proposed solution:

function ls_titles_process($op, $text = FALSE, $format = FALSE, $id = FALSE) {

    ....

    case 'set':
      // Calculate $id if not passed by caller (for Language Sections 2.5 or earlier.)
      if (!$id)  {  
        $id = ls_titles_get_id($text, $format);
      }

      ....
 

This should make it work the way it was originally intended, whereas I think your proposed patch may have undesired side-effects.

Again, IMHO this is an LS Extras issue, not Language Sections.

Now fixed in cvs, and to be released as 1.9.

Fixed, tested and released as 1.9.