FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/login_frequency/login_frequency.links.menu.yml
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/login_frequency/login_frequency.permissions.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/login_frequency/login_frequency.module
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
12 | WARNING | [x] Unused use statement
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/login_frequency/src/Controller/LoginFrequencyController.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
94 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
102 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
114 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------
Time: 97ms; Memory: 10MBrun the following command: phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/login_frequency
fix all the PHP coding standard issues/warnings
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | patch applied.png | 57.71 KB | annmarysruthy |
| #2 | 3343091-2.patch | 4.7 KB | sahil.goyal |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
sahil.goyal commentedFixing all the PHP coding standard issues and warnings, please review.
Comment #3
annmarysruthy commentedComment #4
annmarysruthy commentedReviewed patch #2. patch applied cleanly and phpcs issues are fixed.
Comment #5
annmarysruthy commented