Node Edit Location Form Fields Do Not Populate, Despite Data Being Available To It.

So, here is the culprit.

0.621location_load_location
SELECT * FROM Main_location WHERE lid = 0
0.441location_fax_locationapi
SELECT fax FROM Main_location_fax WHERE lid = 0
0.471location_phone_locationapi
SELECT phone FROM Main_location_phone WHERE lid = 0

Courtesy of the Devel module.

I need to figure out who called this and gave it the value of 0... and I mean, after all... this damn thing is the 3rd time it's called. This one is recursive for multiple values and it populates the form.

The only place I can find that function doesn't respond to echos or anything.

Any ideas?

I found the culprit... and I have no idea why it's like this...

<?php

//LINE 217 LOCATION.MODULE

  if (isset($element['#default_value']['lid']) && $element['#default_value']['lid']) {
    // Keep track of the old LID.
    $element['lid'] = array(
      '#type' => 'value',
	  '#value' => '1217',
      //'#value' => $element['#default_value']['lid'],
    );
  }

?>

I have to tell you, once you make any changes to the database, this code completely messes everything up.
Say you increment all your LIDs by one? Or rego with a script over the database? Everything is completely screwed.

I am going to say this now: I am removing this line of code, and thus far it runs better. No side effects.

My next task ? Merging the redundant location[] and locations[] arrays.

If anyone actually reads my posts let me know... because I have fixed two things wrong about locations xD

Turns out it was a bit more complex. This function is only retrieving bad data seeded by another function that caches the CCK information.
Clearing th caches and dumping location_cck_field switch op load reveals that &$items is blank.

Got to find out why it's being passed in to the function blank.

Got it.

If you don't submit a node through the form, all your fancy functions don't get saved and $element['default_value'] never gets populated.

Need to figure out how to do that in a programmatic fashion, or by hand... ha..