Closed (fixed)
Project:
Location
Version:
5.x-2.7
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
25 Nov 2005 at 10:27 UTC
Updated:
4 Nov 2008 at 23:52 UTC
Jump to comment: Most recent file
if "User locations" is set to enable in location.module admin, the module collect location infos on account update but not on register.
It may be not an issue, but a willing, I don't know.
don't have time to do a patch so, to correct this bug:
replace
if ($op == 'form' && $category == 'account' && $user_setting == LOCATION_USER_COLLECT) {
in function location_user($op, &$edit, &$user, $category = NULL)
by
if ((($op == 'form' && $category == 'account') OR $op == 'register') && $user_setting == LOCATION_USER_COLLECT) {
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | location.module_11.patch | 10.16 KB | webchick |
| #1 | location.module_1.patch | 1.27 KB | webchick |
Comments
Comment #1
webchickExcellent, thanks! Here is a patch. Worked like a charm. :)
Comment #2
ankur commentedI'm weary about committing a patch that automatically adds a user-address form to the registration page even if the setting is selected. I'd prefer a patch that would make this configurable. It would be a "sub-option" of the location_user setting that would ask if the address form for collecting user addresses should also be displayed on the registration page.
-Ankur
Comment #3
webchickI need this for planetsoc.com, so I'm going to roll a patch. My plan is to add a checkbox or whatever for "gather location information on user registration," as well as hook_form_alter the user settings form to add a location selection similar to what is shown in node forms (allow/require X fields) -- I only want to store city, province, and country not the rest.
Comment #4
webchickComment #5
webchickThis seems to do it:
1. Added to the description under "enable user locations" to refer folks to admin/settings/user to set additional options.
2. Under admin/settings/user, added a full-blown location customization form like there are under the node type settings. This way you can specifically allow/disallow/require whatever fields you want.
3. Also added a checkbox to optionally show location info on registration form.
Comment #6
terrybritton commentedExactly what I need, anything like this for 5.X?
Comment #7
catchMaking this the main issue to mark dups against.
like this: http://drupal.org/node/181161
Comment #8
bdragon commentedFixed as part of #324430: [master] [meta] Location settings revamp and #286450: Location on registration?.
Comment #9
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.