Closed (fixed)
Project:
Live JS
Version:
6.x-0.3
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Jun 2011 at 07:39 UTC
Updated:
2 Nov 2013 at 00:30 UTC
Jump to comment: Most recent
First of all, cool work. Not really an issue but something worth considering:
It would be easier to mantain and update the script if the Live.js would live in the libraries folder.
Possibly use http://drupal.org/project/libraries ?
Comments
Comment #1
doublejosh commentedGood thought.
Seems like the *right* way to do it.
I normally maintain a sites/all/libraries folder for including things without a module.
Bit of a bummer to add another dependency to such a small third-party module.
Comment #2
MacRonin commentedCouldn't it just be setup to check the /libraries/ folder first? If there use it, otherwise fallback to current behavior. That would let it take advantage if used, but not create a dependancy.
Might consider an option on the Admin settings to show using /libraries/preferred to cut overhead of checking each time.
Comment #3
doublejosh commentedGotcha. Great suggestion. Much easier.
Got this worked up with caching if it's in libraries after the file_exists() test.
Also clearing that cache, just in case, whenever the environment is switched.
Can imagine situations where this module is set to .gitignore and different developers have it in different locations :)
Released.
Comment #4
doublejosh commentedComment #5
anthonyR commentedThanks for the quick update!