First of all, cool work. Not really an issue but something worth considering:
It would be easier to mantain and update the script if the Live.js would live in the libraries folder.
Possibly use http://drupal.org/project/libraries ?

Comments

doublejosh’s picture

Assigned: doublejosh » Unassigned
Status: Closed (fixed) » Active

Good thought.
Seems like the *right* way to do it.
I normally maintain a sites/all/libraries folder for including things without a module.

Bit of a bummer to add another dependency to such a small third-party module.

MacRonin’s picture

Priority: Normal » Minor

Couldn't it just be setup to check the /libraries/ folder first? If there use it, otherwise fallback to current behavior. That would let it take advantage if used, but not create a dependancy.

Might consider an option on the Admin settings to show using /libraries/preferred to cut overhead of checking each time.

doublejosh’s picture

Status: Active » Fixed

Gotcha. Great suggestion. Much easier.

Got this worked up with caching if it's in libraries after the file_exists() test.

Also clearing that cache, just in case, whenever the environment is switched.
Can imagine situations where this module is set to .gitignore and different developers have it in different locations :)

Released.

doublejosh’s picture

Assigned: Unassigned » doublejosh
Status: Active » Closed (fixed)
anthonyR’s picture

Thanks for the quick update!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.