Make the Live CSS administration pages dependent on the Live CSS permission.

CommentFileSizeAuthor
#1 live_css-manage_permissions-1451742.patch1.83 KBhles

Comments

hles’s picture

hles commented
Status: Active » Needs review
StatusFileSize
new live_css-manage_permissions-1451742.patch1.83 KB

Better permissions, adds a permission for administer the editor, removes 'edit css' permission check in live_css_save and adds it in hook_menu instead where the callback is defined.

guybedford’s picture

guybedford commented

Great thanks, looks good. Will add it to the next release.

guybedford’s picture

guybedford commented
Status: Needs review » Closed (fixed)

I've included this in the latest release. I haven't provided the administer css permission, because there is no distinction between full and reduced live css access with this module. The primary user at the moment is the developer, not the site owner.

Particularly, if we're going to distinguish for a Live CSS administrator and a Live CSS user, then we should be addressing #1293120 first.

It really depends on how much people consider this module for use by site users as opposed to just for development, which has been the primary use case up to now.