Problem/Motivation

Upgrading to 1.8 version get the error:
Parse error: syntax error, unexpected '(' in .../sites/all/modules/link/link.module on line 1376

Steps to reproduce

Upgrade to version 7.x-1.8

CommentFileSizeAuthor
#5 link-n3209434-5.patch2.19 KBdamienmckenna
#2 link-n3209434-2.patch407 bytesdamienmckenna

Comments

tiziano.sartori created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new link-n3209434-2.patch407 bytes

Dangit. Sorry about that. This is a syntax bug that PHP 7 ignores but PHP 5.3 fails on.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3209153: Plan for Link 7.x-1.9
tiziano.sartori’s picture

tiziano.sartori commented

I confirm is related to PHP 5.4

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new link-n3209434-5.patch2.19 KB

There were more occurrences of the same bug.

jmohino’s picture

jmohino commented

Hello everybody. I have had the same problem when updating to version 7.x-1.8 with php 5.4.16, with the link.module file but in the lines:

1376, 1390, 1409, 1430, 1442, 1460 and 1475

After the parentheses are removed, the site is back up and running.
Thanks for the help.

  • DamienMcKenna committed 385e3f7 on 7.x-1.x 
    Issue #3209434 by DamienMcKenna, tiziano.sartori: Syntax error,...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I released 7.x-1.9 with this fix: https://www.drupal.org/project/link/releases/7.x-1.9

Sorry about this slipping under the radar, we'll be more careful with future releases.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.