The theme functions do extra processing before they check if a URL value is present, they should first check if the URL is present and only then do extra processing.

CommentFileSizeAuthor
#6 link-n3178419-6.patch4.41 KBdamienmckenna
#6 link-n3178419-6.interdiff.txt406 bytesdamienmckenna
#4 link-n3178419-4.patch4.41 KBdamienmckenna
#4 link-n3178419-4.interdiff.txt408 bytesdamienmckenna
#2 link-n3178419-2.patch4.41 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new link-n3178419-2.patch4.41 KB

This seems better. Hopefully the tests pass.

Status: Needs review » Needs work

The last submitted patch, 2: link-n3178419-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new link-n3178419-4.interdiff.txt408 bytes
new link-n3178419-4.patch4.41 KB

I borked an if() statement. Doh!

Status: Needs review » Needs work

The last submitted patch, 4: link-n3178419-4.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new link-n3178419-6.interdiff.txt406 bytes
new link-n3178419-6.patch4.41 KB

Another borked if() statement.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed e16b28e on 7.x-1.x 
    Issue #3178419 by DamienMcKenna: Simplify the theme functions.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.