Problem/Motivation

Search popup has incorrect top offset for certain screen sizes: between 768 and 1024px

Steps to reproduce

Resize the browser and open search

Proposed resolution

Fix the offset

Remaining tasks

Review MR

User interface changes

Vertical offset for the search popup is correct across all breakpoints

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 search-modal-responsive.png52.74 KBevilargest
#2 image (17).png330 KBtaran2l

Issue fork la_eu-3588238

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

taran2l created an issue. See original summary.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new image (17).png330 KB

taran2l opened merge request !88

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
evilargest’s picture

evilargest commented
Status: Needs review » Reviewed & tested by the community

The offset size has been fixed so the search modal does not have that huge gap between 768px and 1024px anymore

evilargest’s picture

evilargest commented
StatusFileSize
new search-modal-responsive.png52.74 KB

The width of the responsive modal looks better now, with no gap on the right side of the screen (see the screenshot)

  • taran2l committed bd11ce21 on staging 
    fix: #3588238 Search popup has an incorrect top offset for certain...
taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • taran2l committed bd11ce21 on 2.x 
    fix: #3588238 Search popup has an incorrect top offset for certain...

  • taran2l committed bd11ce21 on downstream/la_nl 
    fix: #3588238 Search popup has an incorrect top offset for certain...