Problem/Motivation

Our plugin has a lower-case class name, which is apparently frowned upon.

Maybe we should rename the class, could probably do this in some kind of BC way, using a subclass I reckon.

Might get hairy if there are any classes extending ours, but I think we essentially provide a BC layer, in the last release of the 1.x series, and there really won't be anyone extending out class, will there.

Steps to reproduce

Run PHPCS

Proposed resolution

Introduce a new 'base' class with an properly cased name, and the existing class can be a trivial extension of that.

Remaining tasks

Do the code.

User interface changes

None.

API changes

A class is going to get deprecated, and go away in the 2.x branch.

Data model changes

None.

Issue fork kraken-3586752

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

steven jones created an issue. See original summary.

steven jones’s picture

steven jones commented
Status: Active » Needs work

Hmmm...I think we'll need to do this in a new version, because actually having the files differing only by case, is going to be tricky!

steven jones’s picture

steven jones commented
Version: 8.x-1.x-dev » 8.x-2.x-dev

steven jones opened merge request !10

steven jones’s picture

steven jones commented

Oh, we can rename our class to not be called kraken and that would be fine.

steven jones’s picture

steven jones commented
Version: 8.x-2.x-dev » 8.x-1.x-dev
Status: Needs work » Reviewed & tested by the community

Locally tested, and this is working on 8.x-1.x.

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed

Merged this change in.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.