I have the issue reported here http://drupal.org/node/234744
The module works great, except for the javascript bookmarket. When I click on the bookmarklet, I am notified that the "URL shortcut was successfully created and there is a short url, but the Target URL is empty. Creating a short url from the form works fine.

I am using php-5.2.12-3.el5
mysql-server-5.0.90-1
on CentOS 5.4.

The client is Firefox 3.6.1 on Centos 5.4

CommentFileSizeAuthor
#6 712890.patch2.2 KBdevkinetic
#3 knurl_module.patch409 bytesdevkinetic

Comments

johnthomas00’s picture

johnthomas00 commented

Just confirmed with client of Windows XP with Firefox 3.6 and/or IE 8.

devkinetic’s picture

devkinetic commented
Assigned: Unassigned » devkinetic

I'll take a peek at this. TBH I figured the old developer had it working right and didn't test it along with all the new stuff I redid.

devkinetic’s picture

devkinetic commented
Status: Active » Needs review
StatusFileSize
new knurl_module.patch409 bytes

Array issue, resolved with patch. Let me know how this works

devkinetic’s picture

devkinetic commented
Status: Needs review » Fixed

Committed to dev release.

johnthomas00’s picture

johnthomas00 commented
Status: Fixed » Needs work

Thanks for working on this.

I tried the dev release and now the bookmarklet works, but the links are broken. When I click on a shortcut, I end up with this in the address bar
http://www.example.com/url/http
and a Page not found error.

devkinetic’s picture

devkinetic commented
StatusFileSize
new 712890.patch2.2 KB

Issue resolved, the URL needed to be encoded in the query string then decoded by drupal before submission. Please delete your shortcut and drag the new one onto your favorites/bookmarks.

Patch provided, and I also committed it to the dev release, give it some time to rebuild and you should be good to go.

devkinetic’s picture

devkinetic commented
Status: Needs work » Needs review
johnthomas00’s picture

johnthomas00 commented

I am still getting http://www.example.com/url/http or http://www.example.com/url/https page not found when click on links. This result happens on a fresh install and whether the link was created via the bookmarklet or via http://www.example.com/knurl/create.

Perhaps someone else can confirm to be sure there is not something in my setup.

Thanks again!

devkinetic’s picture

devkinetic commented

You sure you installed the development version? The issue had to do with escaping the URL which has been added in. That's also odd your getting that using the form as well.

I'll start from square one and do a fresh install of the development copy. Also please remember to delete your old bookmarket and use the new one, with the following at the end

+encodeURIComponent(location.href)

johnthomas00’s picture

johnthomas00 commented

Yes,
1. installed dev version moments ago from http://ftp.drupal.org/files/projects/knurl-6.x-1.x-dev.tar.gz, and
2. used latest bookmarklet.

It could be my setup (CentOS, PHP 5.2, eaccelerator, Mysql 5.0, clean urls), but I am betting not at the moment.

devkinetic’s picture

devkinetic commented
Status: Needs review » Needs work

I'm moving this month so I'll need some time to look at this, stay tuned.

devkinetic’s picture

devkinetic commented

just an update, I plan on wrapping this little thing up soon.

devkinetic’s picture

devkinetic commented
Status: Needs work » Fixed

Fixed in 1.3 !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.