Is it just me or is the alpha1 version not saving variables? If I hard code the variables in my config file everything works as it should, however if I remove them and just rely on the module nothing is saved. I reinstalled the module, cleared cache, and even tried the dev version. Is anyone else running into this?

CommentFileSizeAuthor
#8 jquery_update-not_saving_variables-2494283-8.patch1.8 KBmpv
#4 not_saving_variables-2494283-4.patch1.13 KBnetsliver

Comments

shane birley’s picture

shane birley commented

I can confirm. Variables are not being committed and remain at installed defaults.

Christopher Riley’s picture

Christopher Riley commented

I downgraded to a older dev copy before the settings were moved into a separate file and got the site back up.

TarKHaoS’s picture

TarKHaoS commented

Issue confirmed here.

netsliver’s picture

netsliver
Primary language French
Location Chelles
commented
StatusFileSize
new not_saving_variables-2494283-4.patch1.13 KB

Hi,

I have the same problem.

Try the attached patch.

Regards

Christopher Riley’s picture

Christopher Riley commented

Thank you for the patch. Would like to see it get committed unless the maintainers want to go a different route.

brankoc’s picture

brankoc commented

Marked #2496425: Configuration fails to store some values as duplicate.

brankoc’s picture

brankoc commented
Issue tags: +configuration

Note that my solution in the duplicate issue was to set the #tree attribute of the fieldsets in jquery_update.admin.inc to FALSE. This will let Drupal store each field in its own record, rather than combine them per fieldset. This seems to be a cleaner solution than the one proposed by the reporter, but I am happy with anything that would fix this.

mpv’s picture

mpv commented
Status: Active » Needs review
StatusFileSize
new jquery_update-not_saving_variables-2494283-8.patch1.8 KB

I don't like the solution in #4 because it's explicitly setting the variables in the validate handler. What @brankoc suggested in the duplicate issue seems like a better solution. Here's a patch implementing his suggestion.

denes.szabo’s picture

denes.szabo commented

I have just tested the patch #8, seems fine, the admin page now saves the settings. Thanks @mpv!

  • RobLoach committed b5e3ab0 on 7.x-3.x 
    Issue #2494283 by mpv, netsliver: Not saving variables
robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed
robloach’s picture

robloach
he/him
commented

Thanks guys!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.