This module uses libraries_get_path(), which is part of libraries.module. That module is not listed in .info, which can cause problems. Attached patch fixes this.

CommentFileSizeAuthor
dependency_libraries.patch307 bytesslashrsm

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

No module should require Libraries, it should be completely optional.

A better solution is to check if the libraries module exists, if it does use libraries_get_path() otherwise just use the path "sites/all/libraries".

david lesieur’s picture

david lesieur commented
Issue summary: View changes
Status: Needs work » Fixed

DamienMcKenna: Although I understand the annoyance of requiring Libraries API for a simple function, I do not like the implications of supporting multiple ways for finding libraries. We use common APIs such as Libraries API to simplify logic in "client" modules, reduce code duplication when multiple modules need the same service, and ensure consistency of behavior across modules (in this case, consistency in how modules find external libraries, which are not necessarily in 'sites/all/libraries').

So I have added the missing dependency. There are plenty of modules that already depend on Libraries API (which stands in the Top 10 most installed D7 modules).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.