Since this project has committed the jQuery mobile library, it may possibly violate the Usage policy on 3rd party libraries, if it is unmodified. If it isn't modified, you should probably remove the library's code from your git repository and provide instructions for users to download the library into their sites/all/libraries folder.

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Issue tags: +Legal

Adding the legal tag.

timcosgrove’s picture

timcosgrove commented

Hi there-

This module contains a fork of jQuery Mobile, and thus I believe does not violate the third-party library policy. This is a small-but-critical patch which, when using AJAX-based page changing, keeps track of which external scripts and stylesheets have already loaded, preventing double-loading. The fork will be maintained as new versions of jQuery Mobile are released until the jQuery Mobile project develops their own solution to this problem, or a pull request is accepted.

Once the jQuery Mobile project deals with this problem in a way that is usable, I will remove the library and post links to downloads for the library.

Let me know if there is any further action I need to keep the forked version of the library with the module.

jpsoto’s picture

jpsoto commented

Likely ... the mentioned Usage Policy should be lightly reworded to deal with such situations.

That is ...

[...] If your module requires non-Drupal code, such as a third-party JavaScript/PHP library, provide a link to where the other code can be downloaded and instructions on how to install it, and patched it if required.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I don't actually see such a patch or fork in the Git repo? The only change I see is:

diff -u jquery.mobile-1.0a1-original/jquery.mobile-1.0a1.js jquery.mobile-1.0a1-in-git/jquery.mobile-1.0a1.js
--- jquery.mobile-1.0a1-original/jquery.mobile-1.0a1.js	2011-03-04 08:33:17.043675001 -0600
+++ jquery.mobile-1.0a1-in-git/jquery.mobile-1.0a1.js	2011-03-04 08:31:31.553675000 -0600
@@ -15,6 +15,7 @@
  *
  * http://docs.jquery.com/UI/Widget
  */
+(function($){
 (function( $, undefined ) {
 
 // jQuery 1.4+
@@ -2818,3 +2819,4 @@
 	$window.load(hideBrowserChrome);
 	
 })( jQuery, this );
+})(jQuery);
timcosgrove’s picture

timcosgrove commented

We generally prefer Mercurial over Git, so most of my personal work was committed to BitBucket.

I will re-enact the fork in the Git repo so you can see it.

timcosgrove’s picture

timcosgrove commented

http://drupal.org/sandbox/tim.cosgrove/1080794

The library has been removed from the module and a patch added to the module, along with a README file with installation instructions. I also made some other minor adjustments.

Let me know if this now meets D.O. standards re: legal use of 3rd-party libraries.

Thanks!

timcosgrove’s picture

timcosgrove commented

Because of the similar names of these projects, I was mistakenly commenting on this theme. All of my comments apply to the issue on the jQueryMobile module, and this issue in particular:

http://drupal.org/node/1080820

Attaching comments from this thread to that issue.

jpsoto’s picture

jpsoto commented

@tim#6 ... imho such an approach should be conformant ...

Thanks a lot for your nice works !!

timcosgrove’s picture

timcosgrove commented

Just to be clear: this project (jquery_mobile) is not my project; I'm not connected with it. My project is currently a sandbox project:

http://drupal.org/sandbox/tim.cosgrove/1080794

I'm hoping for full project access in the next couple days. Drupalcon may make the whole process faster or slower; not sure.

Thanks!