The jQuery plugin provides options for expandEffect, collapseEffect, expandSpeed, and collapseSpeed. These should be exposed as options because slideUp and slideDown are not always the best combo.

CommentFileSizeAuthor
#3 jquery_expander-expand-collapse-effects-2386424-2.patch2.08 KBmavame
#2 jquery_expander-expand-collapse-effects-2386423-1.patch2.08 KBmavame
#1 jquery_expander-expand-collapse-effects-2386423-0.patch2.08 KBmavame

Comments

mavame’s picture

mavame commented
Status: Needs work » Needs review
StatusFileSize
new jquery_expander-expand-collapse-effects-2386423-0.patch2.08 KB

Proposed patch attached.

mavame’s picture

mavame commented
StatusFileSize
new jquery_expander-expand-collapse-effects-2386423-1.patch2.08 KB

Fixed issue with previous patch (typo).

mavame’s picture

mavame commented
StatusFileSize
new jquery_expander-expand-collapse-effects-2386424-2.patch2.08 KB

Fixing issue with previous patch (not good).

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

This looks great. I would say works for me and RTBC.

One minor suggestion to improve the description:

+++ b/jquery_expander.module
@@ -79,6 +83,34 @@ function jquery_expander_field_formatter_settings_form($field, $instance, $view_
+    '#description' => t('Can be slideDown, show, fadeIn, etc.'),

"You may use a valid jQuery effect such as slideDown, show, fadeIn, etc..."