Hi and thanks for this module. It nicely solves the problem I had of requiring admin intervention to grant users' access to medium-security content.

I'd like to see the prompt text corrected, or allow the admin to easily customize it without hacking the module or doing additional theming:

"You can join one of these roles if u know the correct password"
-- change the "u" to "you".

"You can leave one of this roles; you dont need to know the password to leave it"
-- change "dont" to "don't"
-- better: change to "Select a role to leave (password is not required)."

"Do it now" in the button
-- change button text to the usual "Submit" or "Save" found on the rest of the site.

Thanks
Steve

CommentFileSizeAuthor
#9 join_role_with_password_7.x-goodeit.diff4.18 KBgoodeit

Comments

francoud’s picture

francoud commented
Assigned: Unassigned » francoud
Status: Active » Needs work

Yup, you're right. u and "dont" are good for chatting and not for a drupal module ;) OK i'll do my best for the next release :)

francoud’s picture

francoud commented
Status: Needs work » Closed (fixed)

I corrected this in 6.x-1.x-dev and 7.x-1.x-dev. Soon also in newer stable versions.

Thanks.

francoud’s picture

francoud commented

6.x-1.7 and 7.x-1.0 should fix the problem. If U.. ehr.. You find any other typo.. .tell me :)

goodeit’s picture

goodeit commented
Status: Closed (fixed) » Needs work

First, thanks for this module, it is exactly what I was looking for.

It appears that the above suggestion to change "Do it now" to the more standard "Submit" was not implemented. Was that a design decision, or is it possible you could change it?

Furthermore, I would like to request a way to alter the prompt text to a custom setting. The easiest way for you to implement this would probably be to pass all the prompts through t() (http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/t/7). This would allow us to use the String Overrides module to change the text to whatever we want it to be.

Thanks again!

goodeit’s picture

goodeit commented

my apologies! After looking into this, I realized I was using string overrides incorrectly, and in fact you are already using t(). I am in the process of changing some of the wording in the module, I will try and make a patch with the "Submit" (and other small changes for readability) when I am done.

Thanks again for this module!

francoud’s picture

francoud commented
Status: Needs work » Closed (fixed)
goodeit’s picture

goodeit commented
Version: 6.x-1.6 » 7.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new join_role_with_password_7.x-goodeit.diff4.18 KB

here's a patch which adds the ability to translate the title of the menu tab using string overrides, as well as some fixes to match drupal_set_message conventions (start with a capital letter, end with a period) and improve other prompt text.

Thanks again for this great module!