I like this aggregator module but couldn't get it to work properly. After some searching, I find that the problem came from the extraction of path information. So i hope the following quick patch helps (line 46)

        if (base_path() != "/") {
          // to match the modification done in the previous statement
          $base_path = substr(base_path(), 1);
          // find out the length
          $base_length = strlen($base_path);
          // take off the base_length
          $value = substr($value, $base_length);
          // original code
          //$value = substr($value, strpos($value, '/')+8);
        }

Comments

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Needs work

I confirm the problem but not the solution. I think this has something to do with my site being in a subdomain.

When I enable aggregation and load another page or clear the javascript cache, I get this error:

The selected file /tmp/fileKzpHm1 could not be uploaded, because the destination files/js/28bc54484f5b95c90537ba2971c5a101.js is not properly configured.

...but it is, as far as I know. It has the right permissions and everything.

I'm using D5.7, PHP 5.2, MySQL5, and Apache/2.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Active

An actual patch might help.

icecreamyou’s picture

icecreamyou commented

FWIW, it's working on a site using the main domain. I no longer have any sites on subdomains so I can't help with this.

robloach’s picture

robloach
he/him
commented
Status: Active » Fixed

Yeah, I'm assuming this is fixed... If you're using site specific file directories, there shouldn't be a problem.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

deepbluesolutions’s picture

deepbluesolutions commented
Status: Closed (fixed) » Active

This is still an issue for drupal 5.11, javascript_aggregator 5.15, FCKeditor 5.x-2.2-rc6

I have also just upgraded to 5.15, and fckeditor to 5.x-2.2-rc7, with the latest javascript aggregator 5.15. This is still an issue, has anyone got any thoughts on the fix? I checked out the code suggested in this thread but that doesnt really explain the whys and hows. The effect of this bug is that i cannot enable javascript aggregation with fckeditor, and I want to as it improves my Yslow score from 56 to 68 !

I also tried disabling IMCE integration, but that didnt make any difference.

deepbluesolutions’s picture

deepbluesolutions commented
Version: 5.x-1.3 » 5.x-1.5

Hi All

Im not sure why this problem is occuring, when I do an inspect I can see the fckeditor.js and fckeditor_config.js are being excluded from aggregation, but the other fckeditor files are not, the same issue as the original thread posting. If I enable the aggregator it works well, but disables fckeditor from working. When I disable the aggregator, fckeditor works perfectly. The patch suggested on this thread is unclear, and I really dont like the idea of hacking the code. Has anyone experienced this problem ? I have made sure all code is at the latest 5 base, and I have reproduced on a fresh 5.15 install.

deepbluesolutions’s picture

deepbluesolutions commented
Title: Unable to aggregate » fckeditor not working when excluded and javascript_aggregator enabled
deepbluesolutions’s picture

deepbluesolutions commented

Changed title to something more understandable

icecreamyou’s picture

icecreamyou commented
Title: fckeditor not working when excluded and javascript_aggregator enabled » Unable to aggregate
Status: Active » Closed (fixed)

First of all, this thread is about aggregation not working at all, and it's working now. So if you have another problem, you should open a separate issue.

Second, there's probably another JS file in FCKeditor that's not being excluded. Look in your FCKeditor folder and exclude it from aggregation.

deepbluesolutions’s picture

deepbluesolutions commented

Oops IceCreamYou, sorry to confuse the thread. have added to another thread.