After spending a few hours trying to figure out why this module wouldn't work (stepping through JavaScript), I discovered some helpful information that may save others from wasting too much time, and wish to document it somewhere where others can find it.

  • The text format/filter cannot have the "Limit allowed HTML tags and correct faulty HTML" filter enabled. I tried to keep it enabled and added picture, img, source tags, etc., but no matter what I tried to add to the allowed tags, the ckeditor image icon would not appear in the editor when this filter was enabled. (If setting up content-editor roles, it would be nice to restrict the HTML they can enter.)
  • The HTML of the displayed inline image only gets processed in to responsive format (picture/source/img tags) if the inline image was uploaded. I.e., if you try to type a text path for the image, it will render as an unprocessed img tag. So you must enable the "Enable image uploads" option in the "CKEditor plugin settings: Image" panel.
  • I'm still trying to figure out an eloquent way to stop this module from adding width and height = 16 to the img tags, but you could always preprocess this out (hack) in your theme or module, or even more hacky, add css declarations (e.g., width: auto !important) for these inline images.
    • This odd manifestation was due to the filter "Restrict images to this site" being enabled (and erroneously deciding that the image wasn't part of this site). It replaces the source attribute of the img tag with an error icon, but because of the responsive picture/source/img tag html layout, this "error" image in the img tag is not displayed, but rather the responsive image(s) set to 16px width & height, thus causing a bit of confusion.

Comments

jpvivere created an issue. See original summary.

jpvivere’s picture

jpvivere commented
Issue summary: View changes
karolus’s picture

karolus commented

Got this working on my site--will test for other settings.