It is a great module but some bugs need fixing.

I use the drupal 6.25 and inline ajax comment. I found there is a bug that:

If there is no comment in the node, the "Add Comment" link in the "grey box" will not work.

But if I have added a comment in the node page (not inline comment views), then the "Add Comment" link works.

I hope it can be fixed as it should be "normal" for users to add comment always in the "inline comment views".

Thank you so much in advance.

CommentFileSizeAuthor
#5 fix_js_base_path-1533038-5.patch2.89 KBkitkat13
#2 fix_js_base_path-1533038-2.patch1.29 KBderjochenmeyer

Comments

jaykainthola’s picture

jaykainthola commented

I have check this and I found that drupal basepath is not included with url in the js. Due to this, we are getting the url not found error.

I have added basepath with the url and its working fine.

derjochenmeyer’s picture

derjochenmeyer commented
Title: Add comment link not work » Ajax links don't work if basepath is not "/"
Version: 6.x-1.0-beta1 » 7.x-1.x-dev
Priority: Critical » Major
Status: Active » Needs review
StatusFileSize
new fix_js_base_path-1533038-2.patch1.29 KB

This patch adds the basepath to reply.js and loadComments.js

var basepath = Drupal.settings.basePath;
ghankstef’s picture

ghankstef commented

Please clarify this. You've marked this as being the 7.x-1.x-dev branch but then say you are using the Drupal 6 version. I don't know if the patch is for the Drupal 6 or 7 version

derjochenmeyer’s picture

derjochenmeyer commented

The patch is for 7. I never used the 6 version. (that was adamtong with the original issue).

I was changing this issue form 6 to 7.x-1.x because its usually good practice to fix a bug in HEAD first and then backport it to older versions.

Try to install Drupal in a subdirectory and the ajax links stop working.

kitkat13’s picture

kitkat13 commented
StatusFileSize
new fix_js_base_path-1533038-5.patch2.89 KB

This patch adds the basepath to reply.js , loadComments.js , ajaxPoster.js and js/reformatPager.js

simon georges’s picture

simon georges commented
Status: Needs review » Reviewed & tested by the community

It works indeed.

mariafromatoz’s picture

mariafromatoz commented

patch #5 worked like a treat , thanks.

chefdro’s picture

chefdro commented
Status: Reviewed & tested by the community » Active

i added patch 5.. still says "loading..."

the comment does not load.. and add new comment redirects to the post's page.

i use drupal 7.. and module version is 7.x-1.0-beta2

miccelito’s picture

miccelito commented

Mentioned before, the Inline Comments only works with Views format Unformatted (doesn't work for Views format Table).

After adding patch #5 - Inline Comments links (i.e. edit, reply) work in NODES only - but not in VIEWS field Inline Comments.

simon georges’s picture

simon georges commented
Status: Active » Needs work

Needs work, then.

Nicolino77’s picture

Nicolino77 commented

Where are we in this matter?

socialnicheguru’s picture

socialnicheguru commented
Issue summary: View changes

in a view, I get a new page where I can edit the comment. The filter is not selected