Problem/Motivation

Changes to CSS aggregation in Drupal 10.1 can make sites fail with HTTP/500.

Steps to reproduce

Enable the module on Drupal 10.1 with aggregation enabled, observe WSOD.

Proposed resolution

Restore the now deprecated service to the container and figure out something else by Drupal 11.0.

Remaining tasks

One manual test on a real site should suffice.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#8 3365122-8-buying-time.patch1.32 KBluke.leber
#6 3365122-6-buying-time.patch1.31 KBluke.leber
#5 3365122-5.patch8.23 KBsachin.bansal27
#4 3365122-4.patch8.35 KBluke.leber
#3 3365122-3.patch8.11 KBluke.leber
#2 3365122-2.patch3.91 KBluke.leber

Comments

Luke.Leber created an issue. See original summary.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3365122-2.patch3.91 KB
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3365122-3.patch8.11 KB

Well that didn't go well. These changes really disrupted the kernel testing :-(.

How about...this?

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3365122-4.patch8.35 KB

Ran into some manual testing problems -- updated an implementation to work around stream wrapper based resources.

sachin.bansal27’s picture

sachin.bansal27 commented
StatusFileSize
new 3365122-5.patch8.23 KB

Making a fix for non compressed files.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3365122-6-buying-time.patch1.31 KB

This is a radically different approach, after consulting with @cmlara on slack.

Let's see what the test bot thinks...

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
StatusFileSize
new 3365122-8-buying-time.patch1.32 KB

Resolve coding standard violations from #6.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Active » Needs review
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Issue summary: View changes
luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Related issues: +#3394740: Drupal\Core\Asset\CssCollectionOptimizer is deprecated!

Added follow-up issue.

  • Luke.Leber committed e6ad636a on 1.0.x 
    Issue #3365122 by Luke.Leber, sachin.bansal27, cmlara: CSS Aggregation...

Luke.Leber credited cmlara.

luke.leber’s picture

luke.leber
Primary language English
Location Pennsylvania
commented
Status: Needs review » Fixed

Committed and pushed #8 to 1.0.x on the grounds of...

  1. Automated tests are green
  2. Support for Drupal 10.1+ is already broken and the change only applies to 10.1+. What's there to lose?

I'll be cutting a new patch release shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.