Problem/Motivation

In Improved Multi Select, when the “Button text” field is left empty, the button is still rendered in the UI.

This results in:

  • Empty or unclear buttons being displayed
  • Poor user experience

Steps to reproduce

  • Enable the module and configure a field with Improved Multi Select
  • Leave the Button text field empty
  • Save configuration and view the form
  • Save configuration and view the form

Observe that the button is still displayed without proper text

Button

Button

Proposed resolution

  • Do not render the button if Button text is empty
  • Alternatively, enforce validation to require button text
  • Ensure no empty/label-less buttons are output

Remaining tasks

Update render logic to conditionally display button

User interface changes

Buttons will not appear when text is empty

API changes

None

Data model changes

None

CommentFileSizeAuthor
button.png103.17 KBarunkumark
button text.png220.37 KBarunkumark
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

arunkumark created an issue. See original summary.

arunkumark’s picture

Assigned: arunkumark » Unassigned
Status: Active » Needs review