Closed (fixed)
Project:
Import HTML
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Dec 2014 at 06:41 UTC
Updated:
24 Mar 2015 at 22:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jamesdixon commentedHere is the patch we used to allow configuration of the menu link title length.
Comment #2
jamesdixon commentedUpdated the patch to take the title length into consideration in side the import_html_guess_label instead of using hardcoded IMPORT_HTML_MAX_LABEL_LENGTH
Comment #3
dman commented1.
typo
... and I see we already are pre-setting menu_link_max_length in import_html_profile_defaults()
So that's looks like it was a step in this direction a while ago.
So in general it's a useful cleanup.
We can put this in. If you tidy up the typo I think the patch can go in easy.
Comment #4
jamesdixon commentedThanks for the review, I just noticed this while going through the commit logs of our site also. Please find the revised patch attached.
Comment #7
dman commentedThanks!
I'm pushing this in a little blind (untested) as it looks trustworthy and I want to clear the desk here a little before picking up some future dev.