I'm getting a warning message when running Drush that I haven't seen before. This is using Drush 6.5.0, Imageinfo Cache 7.x-3.5, and Drupal 7.36:

Declaration of ApachesolrAttachmentsEntityFieldQuery::finishQuery() should be compatible with EntityFieldQuery::finishQuery($select_query, $id_key = 'entity_id') imageinfo_cache.drush.inc:201
CommentFileSizeAuthor
#2 imageinfo_cache-entityfieldquery-declaration-warning-2469249-2.patch580 bytessgdev

Comments

sgdev’s picture

sgdev commented

Also should add that I think I see the issue. In the function definition, Imagecache Info uses "SelectQuery," while core's entity.inc does not. As soon as I remove SelectQuery to match core, I don't see the warning message.

This occurs on line 219 in imageinfo_cache.drush.inc, and line 1319 in /includes/entity.inc:

Imageinfo Cache Version:

public function finishQuery(SelectQuery $select_query, $id_key = 'entity_id') {

Core Version:

function finishQuery($select_query, $id_key = 'entity_id') {
sgdev’s picture

sgdev commented
Version: 7.x-3.5 » 7.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new imageinfo_cache-entityfieldquery-declaration-warning-2469249-2.patch580 bytes

Here's a patch for review.

joshtaylor’s picture

joshtaylor commented
Status: Needs review » Reviewed & tested by the community

Looks good, fixes PHP7 issues.

  • mikeytown2 committed b2e54d4 on 7.x-3.x authored by ron_s 
    Issue #2469249 by ron_s: EntityFieldQuery declaration warning when...
mikeytown2’s picture

mikeytown2 commented

committed #2

mikeytown2’s picture

mikeytown2 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.