Hello again :)

imagefield_archive only supports archiving images in image fields. I know, the name already implies this, but I was lazy in reading it before I installed it :P. I'd like it to work with the image module as well.

In looking through the code, it appears that extending it to support images from the image module shouldn't be too hard. Since I don't see any other module to do this yet, would you be open to adding this feature? I could probably write it as a separate module, but IMO extending this one would be slick, cause you could write a view with a mix of the two (image mod/imagefields), and have it happily spit out a zip file with the mix of files.

Thanks,
Al

CommentFileSizeAuthor
#5 imagefield_archive-756882-5.patch4.36 KBcaptainack
#4 imagefield_archive-756882-4.patch3.28 KBcaptainack
#3 imagefield_archive-756882-3.patch0 bytescaptainack

Comments

infojunkie’s picture

infojunkie
Location Vancouver
commented

Yes I would be interested in extending the module to support Image. If you're willing to code this, please submit your patch here and I'll be happy to discuss it.

captainack’s picture

captainack commented

Excellent. I'll try to submit one by tomorrow.

Thanks,
Al

captainack’s picture

captainack commented
Status: Active » Needs review
StatusFileSize
new imagefield_archive-756882-3.patch0 bytes

This appears to work, however:

1. My zip files come in as just ".zip"... How do I get to the form that lets me specify the file name with the token replacements, etc? I see all the code for it, but don't know how to get to it. I don't see it within views, and I can't find a VBO admin page...
2. I haven't tested it to see if it breaks filefields yet, because I don't have any proper content types.
3. Visually, it looks to me like there's an unrelated bug on line 34, whereby if "original" is selected, filepath, filename, and presetname aren't populated. In the "image" case, this failed. Again, I can't test this though.
4. I tried to stick as closely to your original code as possible, but since image and imagefield do things slightly differently sometimes, I had to diverge a bit in some spots.

Thanks,
Al

captainack’s picture

captainack commented
StatusFileSize
new imagefield_archive-756882-4.patch3.28 KB

Whoops! empty file :-S

Here it is again.

captainack’s picture

captainack commented
StatusFileSize
new imagefield_archive-756882-5.patch4.36 KB

1. Apparently the options don't show up in VBO 1.9. I upgraded to the dev version of VBO-1.x and they showed up. They also forced me to make a few changes. New patch attached.
2. Still the case...
3. Apparently not ;)

Please let me know if you have any inputs.

Thanks!
Al

infojunkie’s picture

infojunkie
Location Vancouver
commented
Status: Needs review » Fixed

Committed in latest dev. Thanks for the great patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.