In case that exactly one image is required (i.e. the 'required' setting is checked and 'multiple values' is unchecked), the 'delete' checkbox seems to be pointless in the imagefield widget form. This might be confusing for a user. I'm attaching a simple patch that displays the checkbox only when it is appropriate.

CommentFileSizeAuthor
imagefield.module.deleteCheckBox.patch827 bytesmcvecka

Comments

dopry’s picture

dopry commented
Version: 5.x-2.x-dev » 6.x-3.x-dev

This goes into 2.1

xiong’s picture

xiong commented

I think the delete button is useful, because sometimes I upload a wrong picture, and I would like to change that. So either we have a delete button, or we have a "change picture" button for those already uploaded pictures.

bobdalob’s picture

bobdalob commented

With only one image, uploading another one replaces the existing image hence the delete button isn't necessarily required. In fact, with the help text, it seems logical and it makes sense to remove the delete box as that may only confuse matters

xiong’s picture

xiong commented

yep that's true.

dopry’s picture

dopry commented
Status: Needs review » Closed (won't fix)

What if the user decides they don't want an image there at all... this won't go in...

jpetso’s picture

jpetso commented
Status: Closed (won't fix) » Needs review

I think the point was that if the field is both required and not multiple, the user has no choice other than uploading exactly one image. Thus it's also not possible to delete the image without failing the node submission.

dopry’s picture

dopry commented
Status: Needs review » Closed (won't fix)

not an issue in 6.x and i won't be fixing in 5.x... It's lived this long without it...