The API allows you to specify the quality level. I'd like to be able to use that.

CommentFileSizeAuthor
#7 imageapi_optimize-3021489-7.patch1.73 KBamoebanath
#3 imageapi_optimize-3021489-2.patch1.73 KBamoebanath

Comments

amoebanath created an issue. See original summary.

steven jones’s picture

steven jones commented
Status: Active » Postponed (maintainer needs more info)

Thanks for the feedback!

Which API has a quality option that you'd like to support?

How would you like to use it?

amoebanath’s picture

amoebanath commented
Title: Support quality option » Kraken: Support quality option
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new imageapi_optimize-3021489-2.patch1.73 KB

Kraken! Patch! :)

amoebanath’s picture

amoebanath commented
Assigned: amoebanath » Unassigned

Status: Needs review » Needs work

The last submitted patch, 3: imageapi_optimize-3021489-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

steven jones’s picture

steven jones commented 
+++ b/modules/kraken/plugins/ImageAPIOptimizeProcessorKraken.inc
@@ -126,6 +138,10 @@ class ImageAPIOptimizeProcessorKraken implements ImageAPIOptimizeProcessorConfig
+      if (!(bool) $this->isLossy() && !empty($this->quality)) {

Is this logic correct?
The description of the quality setting says that this will be sent if using lossy compression, but this looks to only send it if not using lossy compression.

amoebanath’s picture

amoebanath commented
StatusFileSize
new imageapi_optimize-3021489-7.patch1.73 KB

Yes! Classic mistake!
Overthinking several things whilst writing code is not helpful :P

amoebanath’s picture

amoebanath commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: imageapi_optimize-3021489-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.