Your ServiceInterface has to many function.

Your controller doesn't call this function, only your tests.

Maybe these functions would be part of an independent service, not directly from the main service.

Comments

  • Grimreaper committed d168991 on 8.x-1.x 
    Issue #2510228 by ilmir, Grimreaper: Limit ServiceInterface to contract.
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Fixed

Hello,

Thanks for the suggestion. I removed the functions from the service interface.

About the tests I think I need to improve them.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.