swfupload as library

subscribing

Sounds interesting. Will be checked.

patch failed

patch -p0 --dry-run < image_fupload-swfupload_as_library_0.patch 

patching file .//image_fupload_image/image_fupload_image.module
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file .//image_fupload_image/image_fupload_image.module.rej
patching file .//image_fupload_imagefield/image_fupload_imagefield.module
Hunk #1 succeeded at 69 with fuzz 1 (offset 4 lines).
Hunk #2 FAILED at 98.
1 out of 2 hunks FAILED -- saving rejects to file .//image_fupload_imagefield/image_fupload_imagefield.module.rej
patching file .//image_fupload.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file .//image_fupload.info.rej
patching file .//image_fupload.module
Hunk #1 FAILED at 115.
1 out of 1 hunk FAILED -- saving rejects to file .//image_fupload.module.rej
patching file .//swfupload-settings.tpl.php
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file .//swfupload-settings.tpl.php.rej

OK, I reworked this patch. A few notable changes:

1) not all files live in the root of libraries/swfupload/. For instance the .swf lives in Flash/ and the query.js lives in plugins/ so the new code reflects that. This means that when someone downloads the swfupload library, they don't have to move any files around.

2) The hook_requirements() has been updated to check for the files in libraries, with some clearer instructions I think, and it mentions that you have to dl the 2.2.x version. 2.5.x is out now and it doesn't look compatible yet.

oh, and the other thing is that this patch will totally break existing sites, as it has new dependencies and the location sof files isn't the same so we may want to find a way to give people a very clear warning before they upgrade.

Would be great to see this getting committed. Having to copy additional external libraries is a big hassle currently.

Same, looking for this here.

subscribing :P

It's been almost a year since this much needed functionality was submitted as a patch. Is there any reason why it can't be committed?

Agreed, looking forward to this being implemented with library functionality. Subscribing.

+1

+1 and subscribing

Patch failed against RC2

patch < image_fupload-swfupload_as_library_1.patch
patching file image_fupload_image.module
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file image_fupload_image.module.rej
patching file image_fupload_imagefield.module
Hunk #1 FAILED at 65.
Hunk #2 FAILED at 93.
2 out of 2 hunks FAILED -- saving rejects to file image_fupload_imagefield.module.rej
patching file image_fupload.info
patching file image_fupload.install
patching file image_fupload.module
patching file swfupload-settings.tpl.php

And even worse with the latest dev release of image_fupload:

patch < image_fupload-swfupload_as_library_1.patch
patching file image_fupload_image.module
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file image_fupload_image.module.rej
patching file image_fupload_imagefield.module
Hunk #1 FAILED at 65.
Hunk #2 FAILED at 93.
2 out of 2 hunks FAILED -- saving rejects to file image_fupload_imagefield.module.rej
patching file image_fupload.info
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file image_fupload.info.rej
patching file image_fupload.install
Hunk #1 FAILED at 49.
1 out of 1 hunk FAILED -- saving rejects to file image_fupload.install.rej
patching file image_fupload.module
Hunk #1 FAILED at 115.
1 out of 1 hunk FAILED -- saving rejects to file image_fupload.module.rej
patching file swfupload-settings.tpl.php
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file swfupload-settings.tpl.php.rej

Darn.

Tried it with -p0 like frankcarey did and it worked against rc2

patch -p0 < image_fupload-swfupload_as_library_1.patch
patching file .//image_fupload_image/image_fupload_image.module
patching file .//image_fupload_imagefield/image_fupload_imagefield.module
patching file .//image_fupload.info
patching file .//image_fupload.install
patching file .//image_fupload.module
patching file .//swfupload-settings.tpl.php

except now the node edit pages with image_fupload widget are blank :(

+1

Subscribing.