Problem/Motivation

External links inside modals are being prevented from redirecting.

Steps to reproduce

Create a modal, add a link that points externally. View modal and try to click on said link. (Nothing happens)

Proposed resolution

Remove unnecessary e.preventDefault() in modals.js on line 127.

Issue fork ik_modals-3587642

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tomealter created an issue. See original summary.

tomealter opened merge request !7

tomealter’s picture

tomealter commented
Status: Active » Needs review
rosemaryreilman’s picture

rosemaryreilman
she/her
commented

Thanks for reporting and creating a PR. I have this in my queue to review & release.

rosemaryreilman’s picture

rosemaryreilman
she/her
commented
Assigned: tomealter » rosemaryreilman
rosemaryreilman’s picture

rosemaryreilman
she/her
commented
Status: Needs review » Fixed

Merged and Fixed in release 6.0.4

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rosemaryreilman’s picture

rosemaryreilman
she/her
commented
Status: Fixed » Closed (fixed)