Problem/Motivation

When a iframe has been removed because of the removal rules, a moderator might have trouble finding out why it's iframe is not being displayed.

Proposed resolution

Create a permission "Allowed to be notified about removed iframes on current page".
If a user has acces to the above mentioned permission, show them a message about the removed iframe, with some additional information like the URL that was being framed.

Remaining tasks

N/a

User interface changes

N/a

API changes

N/a

Data model changes

N/a

Comments

nielsva created an issue.

yookoala’s picture

yookoala commented

Thanks for the suggestion.

Let's say we can find a way to detect if an iframe is removed by this method, how do you propose the site admin to be notified?

I can think of 3 different ways:

  1. Email, which needs to be fired only once per content. This can be tricky to do so.
  2. Watchdog logging / Logging API. This should be the easiest to do. And I don't think we need to add any permission because its already restricted to site admin.
  3. Site top flash message (a.k.a. Drupal's Messages API)

I'd prefer the later 2 because it's less tricky to implement.

nvaken’s picture

nvaken
he/him
Primary language Dutch
commented

I think 2 and 3 are fine, where the third one seems mandatory to me; when saving a node I'd like to be immediately notified of the removed iframe.

yookoala’s picture

yookoala commented

Given the way pages are cached, body is usually only rendered once for a long while. And a messenger api will only be triggered on this first render.

It might not be possible to show the message on the filtered page everytime (i.e. behaviour 3 I mentioned).

nvaken’s picture

nvaken
he/him
Primary language Dutch
commented

I would be fine with showing the flash message only on a save event, noticing me as moderator of the content that the just-saved content contains a iframe that does not show. Something like:

`Warning: the iframe with the URL has been removed since it is not permitted. Contact site admin to add this URL to the whitelist.`