Ideation for Drupal 7 has a dependency on openpublic_default. If its only useable with openpublic, then why offer it separately?

Comments

santam’s picture

santam CreditAttribution: santam commented

subscribe

irakli’s picture

irakli CreditAttribution: irakli commented
Assigned: Unassigned » irakli

It should not. It's a bug.

Features module extracts extraneous dependencies which sometimes slip through. Will fix.

Thank you

langworthy’s picture

langworthy CreditAttribution: langworthy commented

It's tricky that features.module does this. I think this is a good example of why tests for Kit compliance are a good thing to have #1071272: Test for Kit compliance of Ideation. As far as I know there isn't consensus for how to include Kit tests in Drupal projects but we're trying to figure that out. #1072132: How are compliance tests packaged?.

lloydpearsoniv’s picture

lloydpearsoniv CreditAttribution: lloydpearsoniv commented

I think this could have been avoided if it were simply tested on another distro that wasn't openpublic from the start. There is noway this bug gets by anyone if they actually test it on a non-openpublic system.

irakli’s picture

irakli CreditAttribution: irakli commented

@lloydpearsoniv, just out of curiosity: which other Drupal7 distro do you know?

lloydpearsoniv’s picture

lloydpearsoniv CreditAttribution: lloydpearsoniv commented

Commerce Dev https://github.com/rszrama/commercedev
Open Outreach http://drupal.org/project/openoutreach
Omega Profile http://drupal.org/project/omega_profile
Designer Starter Kit http://drupal.org/project/dsk
Display Suite http://drupal.org/project/displaysuite
Buildkit http://drupal.org/project/buildkit

Thats just what I think of off the top of my head. I use aegir so I try to keep up to date on the latest installation profiles & distros.

langworthy’s picture

langworthy CreditAttribution: langworthy commented

Responding to #4, I agree that it would have helped to test with another distro but I think it would have been even easier to write a Kit compliance test as I mentioned in #3.

lloydpearsoniv’s picture

lloydpearsoniv CreditAttribution: lloydpearsoniv commented

So writing a test is easier that installing a feature? Since when?

I simply ran "drush dl ideation", looked in admin/structure/features and saw that it had a dependency on openpublic_default, then reported it here.

langworthy’s picture

langworthy CreditAttribution: langworthy commented

I may not have been clear. I meant to imply that running a drush make kit compliance test would be easier than installing a distribution and then installing a feature and testing for kit compliance.

I think I should have said more efficient rather than easier. Regardless, there's great value in having a written kit compliance test.

lloydpearsoniv’s picture

lloydpearsoniv CreditAttribution: lloydpearsoniv commented

Yeh, but i think its still a good idea to test your features in other distros to make sure they work as they should before you release them. I use the aegir hosting system. Deploying site can be as difficult as filling out a form or as easy as a couple of mouse clicks. If you have any affiliation with phase2technology, I knwo for certain that they have & use the aegir hosting system...atleast they have in times past.

irakli’s picture

irakli CreditAttribution: irakli commented
Title: Why does ideation have an openpublic_default dependency? » Remove dependency on openpublic_default
irakli’s picture

irakli CreditAttribution: irakli commented

Committed: http://drupalcode.org/project/ideation.git/commit/c36087f

Thanks for reporting.

irakli’s picture

irakli CreditAttribution: irakli commented
Status: Active » Fixed
TechDust’s picture

TechDust CreditAttribution: TechDust commented
Status: Fixed » Active

How long does it take for the commit to go through? As of April 5th, it is still dependent on openpublic_default !!!

I'm building a prototype to show to the customer. Should I just start with the openPublic distro?

TechDust’s picture

TechDust CreditAttribution: TechDust commented
Status: Active » Fixed

OK. sorry I just realized you had just edited the ideation.info and removed the dependency.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rsteer’s picture

rsteer CreditAttribution: rsteer commented
Status: Closed (fixed) » Needs work

As of Jan 6, 2012, this bug still exists. I had to manually edit the .info file.

In response to #5 -- besides all these packaged "distros", there's the basic installation that isn't part of any "project", and that's what you get if you use Installatron or another automated app installer on a hosting service.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles commented
Status: Needs work » Closed (fixed)

@rsteer - http://drupalcode.org/project/ideation.git/blobdiff/ae2e3252498679e6cb5b... the change is in, it's just a matter of making a new stable release with this fix in it. Otherwise you can try a git checkout of code to get the latest version. It seems this module doesn't have dev release nodes (that might be helpful to get more testers...).

Claire Hernandez’s picture

Claire Hernandez CreditAttribution: Claire Hernandez commented

I got the same issue, qith a clean drupal install. Did you plan to release it soon ?

drupal@drupal-test:~/www$ drush pml|grep ideation
 Features                             Ideation (ideation)                                          Module  Not installed  7.x-1.0-beta2  
drupal@drupal-test:~/www$ drush en ideation
No release history was found for the requested project (openpublic_defaults).                                                                                                         [warning]
Module ideation cannot be enabled because it depends on the following modules which could not be found: openpublic_defaults                                                           [error]
drupal@drupal-test:~/www$ drush status
 Drupal version                  :  7.23                  
 Site URI                        :  http://default        
 Database driver                 :  mysql                 
 Database username               :  drupal                
 Database name                   :  drupal                
 Database                        :  Connected             
 Drupal bootstrap                :  Successful            
 Drupal user                     :  Anonymous             
 Default theme                   :  bartik                
 Administration theme            :  seven                 
 PHP executable                  :  /usr/bin/php          
 PHP configuration               :  /etc/php5/cli/php.ini 
 PHP OS                          :  Linux                 
 Drush version                   :  6.1.0                 
 Drush configuration             :                        
 Drush alias files               :                        
 Drupal root                     :  /home/drupal/www      
 Site path                       :  sites/default         
 File directory path             :  sites/default/files   
 Temporary file directory path   :  /tmp