Closed (fixed)
Project:
ICES
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 May 2013 at 09:40 UTC
Updated:
12 Jun 2014 at 19:34 UTC
Jump to comment: Most recent
I got these right off the bat as drupal status warnings. Maybe b.c of my PHP environment, not sure what they mean.
Strict warning: Declaration of LockSerializer::save() should be compatible with that of Serializer::save() in _registry_check_code() (line 3092 of /includes/bootstrap.inc).
Strict warning: Declaration of LockSerializer::updateField() should be compatible with that of Serializer::updateField() in _registry_check_code() (line 3092 of /includes/bootstrap.inc).
Strict warning: Declaration of Exchange::loadRecord() should be compatible with that of DBObject::loadRecord() in require_once() (line 839 of /sites/all/modules/ces/ces_bank/ces_bank.logic.inc).
Strict warning: Declaration of LocalAccount::loadRecord() should be compatible with that of DBObject::loadRecord() in require_once() (line 1118 of /sites/all/modules/ces/ces_bank/ces_bank.logic.inc).
Strict warning: Declaration of LimitChain::loadRecord() should be compatible with that of DBObject::loadRecord() in require_once() (line 1269 of /sites/all/modules/ces/ces_bank/ces_bank.logic.inc).
Comments
Comment #1
hongpong commentedInconsistencies in object passed by reference makes warnings. In the parent class methods there are usually not ampersands with the parameter, but there are in the child methods.
Strict warning: Declaration of Exchange::loadRecord() should be compatible with that of DBObject::loadRecord() in require_once() (line 931 of ssites/all/modules/ces/ces_bank/ces_bank.logic.inc).
in ces_bank.logic.inc:
etc. I think this is the same general condition on all of these.
Comment #2
esteve.badia commentedOk, I changed my php environment and reproduced the bug. Indeed it seems exactly what you pointed out. So I'm going to fix it and pass the tests.
Comment #3
esteve.badia commentedFixed all these warning issues. Apart from the discussed strict warnings, there were a pair of more subtle notices that were exposing actual bugs. Concretely, I wasn't calling the proper user validate functions from the exchange creation form.
A bad side effect of this commit #9f5db62 is that the current create exchange form does not have default values in the Administrator tab. And it is a bit tricky to add them. So in order to have a coherent form perhaps an option is to empty all other default fields.