httprl_requirements() hardcodes timeouts for the lock and connection attempts (7 and 5 seconds, respectively). This can cause the connection tests to fail when the connection takes longer than that (an average of 7 seconds on our site).

I don't full understand the logic used to test self-callbacks, but it seems like it should respect the default timeout configuration rather than hardcoding it. I can guess why it was hardcoded in the first place- to keep status report page loads snappy- but this solution simply doesn't work for some sites.

CommentFileSizeAuthor
#2 httprl-2466959-2.patch939 bytesdanepowell
#1 httprl-2466959-1.patch1.28 KBdanepowell

Comments

danepowell’s picture

danepowell commented
Status: Active » Needs review
StatusFileSize
new httprl-2466959-1.patch1.28 KB
danepowell’s picture

danepowell commented
StatusFileSize
new httprl-2466959-2.patch939 bytes

Actually I think I'm starting to understand this better... and also not understand it at all :)

It seems like the connection attempt will _always_ take the full time (7 seconds) allotted to the lock. Since the success conditional checks whether the connection took less than 5 seconds, it will always fail.

I honestly have no clue how this is _supposed_ to work, but just bumping up the success threshold a bit fixes it.

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Closed (duplicate)

#2492479: Remove variable_set inside the requirements hook.

2 new variables are inside the above patch
httprl_install_lock_time - 7
httprl_install_connection_time - 5