Currently the config entities that represent HTTP config requests are only linked to their respective service api. It would be nice if the were also linked to the module that implements the service api.
Add a config dependency on the module that implements the service api. This has the additional benefit of ensuring the module is installed before importing and automatically deleting the config if the module is uninstalled.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
rocketeerbkw commentedI added a
calculateDependencies()function to the config request entity. This adds a module config dependency every time a new one is created or updated.I briefly explored creating a
hook_update_nto make this change for all existing HTTP config requests, but I wasn't sure what the best practice is for config entities. I think the typical workflow of importing config in production, then running database updates wouldn't be compatible with this. It would be nice to update existing config entites, and if you know what the correct method of doing it would be, I'll make it happen. But otherwise, I'll say it's a nice to have and not required.Comment #5
aronne commentedHi and thank you again for your contribution @rocketeerbkw.
Patch applied :)
Regards,
aronne