Migrate does not update the file paths (ex: file_public_path) in the drushrc alais [#3186406]

Problem/Motivation

When sites are migrated, the file paths are not updated in the drushrc alias file.

Steps to reproduce

Create a site, such as site1.example.org
Migrate it to site2.example.org

Then grep for "file" in the `~/.drush/site2.example.org.alias.drushrc.php`. It will display the old URLs.

Verify does not fix this issue, unless we first manually edit the drushrc file.

Comments

Comment #1

4 December 2020 at 00:50

bgm created an issue. See original summary.

Comment #2

kienan CreditAttribution: kienan commented 4 December 2020 at 16:50

I was able to reproduce this in 7.x-3.190 both 7.x-3.191 ("testing" - 2020.12.04)

Comment #3

bgm CreditAttribution: bgm commented 4 December 2020 at 20:51

I only had a quick look, but found that the drush alias file is rewritten here:

* file: platform/migrate.provision.inc
* function: drush_provision_drupal_post_provision_migrate

I don't know whether "d()->write_alias();" gets called from there (if rename) or from import.

Comment #4

bgm CreditAttribution: bgm commented 4 December 2020 at 21:32

Project:

Provision

» Hostmaster (Aegir)

Comment #5

agaq CreditAttribution: agaq as a volunteer commented 6 December 2020 at 14:25

I reproduced it in 7.x-3.190 (on Ubuntu 18.04, with debian package version 3.190)

I migrated a site 'site.example.com' to 'migrated-site.example.com'.

The migrated site did not display inline images.

`~/.drush/migrated-site.example.org.alias.drushrc.php` still showed the old file paths:

'file_public_path' => 'sites/site.example.com/files',
'file_private_path' => 'sites/site.example.com/private/files',
'file_temporary_path' => 'sites/site.example.com/private/temp',

I updated the paths with new URL:

'file_public_path' => 'sites/migrated-site.example.com/files',
'file_private_path' => 'sites/migrated-site.example.com/private/files',
'file_temporary_path' => 'sites/migrated-site.example.com/private/temp',

Then re-verified the migrated site.

The inline images reappeared.