Right now, hosting_task_TASK_TYPE_form() and hosting_task_TASK_TYPE_form_validate() are in hosting_site.api.php, whereas I believe it would make more sense for them to be in hosting_task.api.php.

Comments

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

We could also provide useful examples, such as:

function hosting_task_backup_form($node) {
  $form['description'] = array (
    '#title' => t('Description'),
    '#type' => 'textfield',
    '#required' => FALSE,
    '#weight' => '-1',
    '#description' => "Describe the reasons for creating this backup."
  );

  return $form;
ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented

And while we're at it, do hosting_task_backup_delete_form() and hosting_task_backup_delete_form_validate() really belong in hosting_task.module? I'd think they should be in site/hosting_site.backups.inc...

anarcat’s picture

anarcat commented

this all makes sense. go.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Active » Fixed

Fixed in 6.x-2.x in f282f497f36a956f8c2a957 and bbc2fc2756551db1.

Also, merged into 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.