I've downloaded Halfstar (cool, the module is finally accepted!) and ran into some issues when voting on a node via comments. When adding the comment, everything seems fine and the users can nicely select half stars (in my test: 3.5 stars). But once the comment is approved

  • the average vote stars aren't always displayed properly (in my test: 4 stars when the 'default' star lay-out is used). It works fine with the 'basic' star lay-out though.
  • the fivestar comment field is displayed incorrectly (in my test: 10 stars are shown and 7 are coloured).

Can this be fixed, please?

Comments

dahousecat’s picture

dahousecat commented

Hi Jeroen,

Thanks for reporting this bug.

I've recreated it so just putting a fix together now.

Cheers,
Felix

  • Commit a007d76 on 7.x-1.x by dahousecat: 
    Issue #2271199: Voting via comments doesn't work properly.
dahousecat’s picture

dahousecat commented
Version: » 7.x-1.0
Status: Needs work » Needs review

I believe I've now fixed this issue and score is now displayed correctly for me when using comments to rate the parent node.

Whilst testing this I did find a bug with the fivestar module that I have reported here.

dahousecat’s picture

dahousecat commented
Status: Needs review » Fixed
Jeroen94’s picture

Jeroen94 commented
Issue summary: View changes

Updating bug report.

Jeroen94’s picture

Jeroen94 commented
Status: Fixed » Needs work

I've downloaded Halfstar's latest version. Apparently, the first remark was bound to the 'default' star lay-out, so I've updated my question. The second problem, however, is still there: 10 stars are displayed in a user's (registered or anonymous) comment, instead of 5.

Are you sure you set-up the voting via comments correctly? In the comment notification e-mail I received, I read that you set the 'Voting target' as 'None', but it should be 'Parent node' (I can't find that comment back...). Maybe that's why you can't reproduce the problem?

dahousecat’s picture

dahousecat commented

I didn't read your question clearly the first time so was not testing the comments vote counting towards the nodes total score, but just voting on individual comments.

I then tested using these instructions and saw the score displayed was wrong, so fixed that.

I haven't been able to recreate 10 stays being displayed but it sounds like the css may not be being loading correctly as only half of each star should be visible. Can you verify if halfstar.css is loaded - and maybe try clearing your cache?

Jeroen94’s picture

Jeroen94 commented

I think you finally determined the cause of the problem. :) When inspecting the stars with Firebug, I notice that it's using the CSS from the 'basic' lay-out from Fivestar, instead of Halfstar. Clearing caches doesn't help.

Maybe it's helpful for you to mention that the stars are displayed perfectly in the comment when I delete the halfstar_comment_view() at the very end of the halfstar.module file. The stars are still using the CSS from Fivestar, but they look as they're supposed to.

dahousecat’s picture

dahousecat commented

Hmm, I still can't recreate the bug. I'll look further into this tomorrow to see if I can spot what could be causing it.

  • Commit 83d77ac on 7.x-1.x by dahousecat: 
    Issue #2271199: Remove halfstar_comment_view() as suggested by Jeroen94...
dahousecat’s picture

dahousecat commented
Status: Needs work » Closed (fixed)

I've removed halfstar_comment_view() as you suggested and made a couple of other tweaks and all seems to be working well during my testing although as I never recreated the 10 stars showing bug I would be keen to hear if the issue is now fixed for you.

I've committed my changes however I noticed that whilst they appear in this thread and this page the main download on the project page of the zip or tar has not yet been updated - I assume this is done via a cron tasks so will just wait for now but in the mean time cloning the git repository will contain the updated file.

Thanks for your help on this issue. Is good to release something I wrote so want to make sure I get all of these bugs ironed out :)

Jeroen94’s picture

Jeroen94 commented

It all works perfectly for me now. Thanks a lot Felix!

dahousecat’s picture

dahousecat commented

Good good, glad that is working property for you now.

This fix is now included in branch 7.x-1.1.