Once #3028340: Create a central service that calculates someone's group permissions lands, we can clean up the now duplicate code in GroupPermissionsHashGenerator.

CommentFileSizeAuthor
#8 group-3028346-8.patch34.14 KBkristiaanvandeneynde
#5 group-3028346-5.patch34.13 KBkristiaanvandeneynde
#2 group-3028346-2.patch34.04 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new group-3028346-2.patch34.04 KB

This moves the hash generator test to a unit test that no longer thoroughly checks caching as the CalculatedGroupPermissions object has cacheable metadata that is being passed around and said system is already thoroughly tested to work in core. This also removes the deprecated code from the hash generator as the next release should be 8.1.0

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Title: [PP-2] Update the GroupPermissionsHashGenerator to use the calculated permissions » Update the GroupPermissionsHashGenerator to use the calculated permissions
Status: Needs work » Needs review

Parent issue landed, let's run some tests

Status: Needs review » Needs work

The last submitted patch, 2: group-3028346-2.patch, failed testing. View results

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3028346-5.patch34.13 KB

Oh, right... old patch won't apply obviously :D

Status: Needs review » Needs work

The last submitted patch, 5: group-3028346-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Call to undefined method Prophecy\Prophecy\MethodProphecy::shouldBeCalledOnce(), uhm.. okay?

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Needs review
StatusFileSize
new group-3028346-8.patch34.14 KB

Tesbot issue: #3028372: Testbot seems to choke on Prophecy version.
Attached patch proves this works with older Prophecy versions

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Screw it, moving ahead with ugly Prophecy code as committing the newer one will make all tests fail for all issues...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.