Right now, a GroupContentEnabler plugin can be installed and uninstalled on a GroupType by the click of a button. This should feel more powerful as it's a very impactful thing to do. Furthermore, plugins can be made configurable so why don't we do that on the installation form?

Tasks:

  • Remove the current install/uninstall routes and controller callbacks
  • Implement the plugin configuration form on entity.group_content_type.add_form and entity.group_content_type.edit_form
  • Create a confirmation form for plugin uninstallation
  • Make sure the plugin configuration is saved on the GroupType
  • This code should live in GroupContentTypeController instead of GroupTypeController
CommentFileSizeAuthor
#2 group-2693223-2.patch14.61 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs work
StatusFileSize
new group-2693223-2.patch14.61 KB

An MVP patch that already moves the installation/uninstallation of plugins to forms. All that needs to be done now is add config forms, validate and submit handlers to the plugins and then implement those in the GroupContentTypeForm class from this patch.

Also, instead of creating/deleting GCTs when installing a plugin, consider letting the forms do so. Their initial purpose is to actually creating and deleting a GCT, so we may as well move that logic back to the forms now that we have them.

Therefore: Needs work.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs work » Fixed

Could use some follow-up love on how plugin config is saved, though.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.