Hi Jim

I get the notice mentioned in the title. I know I is a small issue, but it can be annoying on
development installations where notices are switched on. A possible quick fix for the install
file is provided below. Could it help as well to add the grammar parser itself into the requirements
of the info file, so that the constants, or renaming the constants a bit if the module needs its own,
independent defaults?

Cheers,

Stefan

/**
 * Minimum recommended value of PHP memory_limit.
 */
if (!defined('PARSER_MINIMUM_PHP_MEMORY')) define('PARSER_MINIMUM_PHP_MEMORY', '128M');

/**
 * Minimum recommended value of PHP max_execution_time.
 */
if (!defined('PARSER_MINIMUM_PHP_TIME')) define('PARSER_MINIMUM_PHP_TIME', '30');

Comments

NROTC_Webmaster’s picture

NROTC_Webmaster commented

I added it to the grammar_parser_lib/gplib.install file first and then had to go and add it to the grammar_parser/grammar_parser.install file to get rid of the notice.

I think it just needs to be taken of one of the projects or this line added to both of them to prevent it from failing.

solotandem’s picture

solotandem commented
Category: bug » support

I run this code all the time on a development environment with notices turned on and never see this error. How are your sites configured? Are you using the latest dev versions of each project?

If you are using the grammar parser library "module" (gplib) with the libraries module, then
- the grammar parser is not installed as a module (it should be in sites/all/libraries)
- its install file is not loaded by PHP
- this error message will not be encountered

Have you read the README file in the grammar parser project (or its project page)? Have you tried the Drush Make file included with gplib?

NROTC_Webmaster’s picture

NROTC_Webmaster commented

solo,

I had initally installed it as a module and then when I went back and installed it as a library I forgot to delete it from the modules which is likely what was causing the error.

While if installed correctly you will never see this I also don't think that it is a bad idea to have the check in the file.

solotandem’s picture

solotandem commented
Status: Active » Closed (works as designed)
alan d.’s picture

alan d. commented

From the readmes, it appears that both can be installed as modules, and I too got these warnings during the install process. I used the latest versions on the project pages, grammar_parser v1.2 as the dev versoin was much older.

    Notice: Constant PARSER_MINIMUM_PHP_MEMORY already defined in require_once() (line 13 of sites\all\modules\grammar_parser_lib\gplib.install).
    Notice: Constant PARSER_MINIMUM_PHP_TIME already defined in require_once() (line 18 of sites\all\modules\grammar_parser_lib\gplib.install).
    Notice: Constant PARSER_MINIMUM_PHP_MEMORY already defined in require_once() (line 13 of sites\all\modules\grammar_parser\grammar_parser.install).
    Notice: Constant PARSER_MINIMUM_PHP_TIME already defined in require_once() (line 18 of sites\all\modules\grammar_parser\grammar_parser.install).
alan d.’s picture

alan d. commented

lol, the next screen gave me the reason why:

Grammar Parser should NOT be installed and enabled as a module.
Grammar Parser should be installed as a library using a 2.x release of Libraries API module.

But from the readme:

If used as a module, then install it in a modules directory. See
http://drupal.org/node/895232 for further information.

Does the repository required *.module files? It seems strange to include a module in this fashion.

solotandem’s picture

solotandem commented

The readme indicates, "If used as a module, then install it in a modules directory." That refers to things like the API project that currently uses the parser as a module. That doesn't imply you get a choice when using it with something like Coder that expects the parser to be a library. When used as a module, then you don't also install the grammar parser library (gplib). When used as a library, then put it in a library directory, don't enable it as a module (which you shouldn't be able to by virtue of its location in the file system), and enable gplib.

Any project hosted on drupal.org is either a module or a theme; drupal.org does not offer other categories. The grammar parser is really a library as none of its code relies on Drupal, and is thus Drupal-agnostic.