Add CI to the project

Issue fork google_map_field-3567850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vladimiraus created an issue. See original summary.

vladimiraus opened merge request !2

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Active » Needs work

shamir.vs made their first commit to this issue’s fork.

shamir.vs’s picture

shamir.vs commented

To resolve the PHPStan failures regarding unknown Feeds classes, we have two primary options:

  1. Sub-module approach: Create a sub-module (e.g., google_map_field_feeds) with an explicit dependency on feeds:feeds. This is generally considered a best practice as it isolates third-party integrations, keeps the main module lightweight, and ensures static analysis tools can discover the required classes.
  2. Composer approach: Add drupal/feeds directly to the main module's composer.json.

I am leaning towards Option 1 for better architectural separation. Are there any other recommendations or preferred patterns the maintainers would suggest for handling this integration?