I get messages when I call GA-counter version: 7.x-2.1+1-dev by our custom modul scald_analytics:

Notice: Undefined property: stdClass::$rows in GAFeed->sanitizeReport()
(line 380 of /var/creative/src/sites/all/modules/contrib/google_analytics_counter/GAFeed.lib.inc).
Warning: Invalid argument supplied for foreach() in GAFeed->sanitizeReport()
(line 383 of /var/creative/src/sites/all/modules/contrib/google_analytics_counter/GAFeed.lib.inc).
I patched this, please review and implement.

CommentFileSizeAuthor
#9 GA-counter-GAFeedlib-GAFeed-sanitizeReport-2140855-9.patch1.86 KBakoe
#1 GA-counter-GAFeedlib-GAFeed-sanitizeReport-2140855.patch1.87 KBk. tadesse

Comments

k. tadesse’s picture

k. tadesse commented
Issue summary: View changes
StatusFileSize
new GA-counter-GAFeedlib-GAFeed-sanitizeReport-2140855.patch1.87 KB

Status: Needs review » Needs work

The last submitted patch, 1: GA-counter-GAFeedlib-GAFeed-sanitizeReport-2140855.patch, failed testing.

plazik’s picture

plazik commented

The same problem has been fixed in Google Analytics Report module #2023745: Notice: Undefined property: stdClass::$rows in GAFeed ---AND--- Warning: Invalid argument supplied for foreach() in GAFeed.

vacilando’s picture

vacilando commented
Title: GAFeed.lib.inc GAFeed sanitizeReport » Notice: Undefined property: stdClass::$rows in GAFeed ---AND--- Warning: Invalid argument supplied for foreach() in GAFeed
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Needs work » Active
Issue tags: -notice

  • Vacilando committed 1c0a4b2 on 7.x-3.x 
    Issue #2140855 by K. Tadesse, Plazik: Fixing error messages.
vacilando’s picture

vacilando commented
Assigned: k. tadesse » Unassigned
Status: Active » Needs review

Fixing the same way as @Plazik in #2023745: Notice: Undefined property: stdClass::$rows in GAFeed ---AND--- Warning: Invalid argument supplied for foreach() in GAFeed. Pushed to dev. Please test.

vacilando’s picture

vacilando commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

akoe’s picture

akoe commented
StatusFileSize
new GA-counter-GAFeedlib-GAFeed-sanitizeReport-2140855-9.patch1.86 KB

Patch update, since patch didn't apply only because of wrong formatting.